Skip to content

Fix(Layout Shift Fix) - Resolved Layout Issues on DarkMode Toggle Button and Full-Screen Modal#124

Closed
nitro56565 wants to merge 4 commits intoaccordproject:mainfrom
nitro56565:nitro56565/layout-fix
Closed

Fix(Layout Shift Fix) - Resolved Layout Issues on DarkMode Toggle Button and Full-Screen Modal#124
nitro56565 wants to merge 4 commits intoaccordproject:mainfrom
nitro56565:nitro56565/layout-fix

Conversation

@nitro56565
Copy link
Contributor

Summary

This PR addresses layout shift issues affecting the DarkToggle Button and Full-Screen Modal, ensuring a smoother and more consistent UI experience.

Changes

  • Fixed unintended layout shift on Full screen modal while on start guide tour.
  • Adjusted positioning of the Darkmode button to prevent UI flickering and unnecessary clicks.

Screenshots or Video

Before

Screenshot From 2025-02-18 22-17-22

After

Screenshot From 2025-02-18 22-19-50
Screenshot From 2025-02-18 22-17-01
Screenshot From 2025-02-18 22-19-07

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

…down)

Signed-off-by: nitro56565 <nitro56565@gmail.com>
Signed-off-by: nitro56565 <nitro56565@gmail.com>
Signed-off-by: nitro56565 <nitro56565@gmail.com>
@nitro56565 nitro56565 requested a review from a team as a code owner February 18, 2025 16:51
@netlify
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit bad8872
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67b4c183cc21e60007f5ec3a
😎 Deploy Preview https://deploy-preview-124--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nitro56565 nitro56565 closed this Feb 18, 2025
@nitro56565 nitro56565 deleted the nitro56565/layout-fix branch February 18, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant